fix: Better exception handling in Rx3Util#68
Merged
kennethjor merged 10 commits intoautonomouslogic:mainfrom Mar 12, 2025
Merged
fix: Better exception handling in Rx3Util#68kennethjor merged 10 commits intoautonomouslogic:mainfrom
kennethjor merged 10 commits intoautonomouslogic:mainfrom
Conversation
jamesoguyer
changed the title
|
|
kennethjor
reviewed
Mar 12, 2025
| assertEquals("java.lang.RuntimeException: test error", ex.getMessage()); | ||
| ex.printStackTrace(); | ||
| assertEquals( | ||
| "java.util.concurrent.ExecutionException: java.util.concurrent.CompletionException: java.lang.RuntimeException: test error", |
Contributor
There was a problem hiding this comment.
This doesn't match exactly, but it's good enough
kennethjor
reviewed
Mar 12, 2025
| var maybe = Maybe.fromFuture(future); | ||
| var ex = assertThrows(RuntimeException.class, maybe::blockingGet); | ||
| ex.printStackTrace(); | ||
| assertEquals("test error", ex.getMessage()); |
Contributor
There was a problem hiding this comment.
I don't know why RxJava's Maybe.fromFuture doesn't wrap it like the others do. I opted to wrap it below to have consistency.
kennethjor
changed the title
Contributor
|
🎉 This PR is included in version 1.9.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Rx3Util.toSingle and Rx3Util.toMaybe methods to improve their behavior and consistency when wrapping CompletionStage objects. The changes include better handling of null values, efficient cancellation, and proper error propagation. Corresponding test cases have been updated to ensure correctness.